Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support figure / image alignment #11

Merged
merged 1 commit into from
Aug 7, 2013
Merged

Support figure / image alignment #11

merged 1 commit into from
Aug 7, 2013

Conversation

jone
Copy link
Contributor

@jone jone commented Jan 3, 2013

The default docutils rst2html renders image alignments using a css-class (and the css-definition in the document head).
The creole implementation strips away the css-class, so we have no alignment information left.

I've implemented a fix which puts the alignment information in the html align attribute of the img tag,
since I think using css is not the creole way.
It's not too beautiful but it works, better ideas are appreciated ;)

I didn't figure what to do with the cross conversion stuff, so i didn't do anything there.

On github, which seems to use creole's rest2html, image alignment currently does not work, as reported in github/markup#163 - it would be great to get this fixed :-)

jedie added a commit that referenced this pull request Aug 7, 2013
Support figure / image alignment
@jedie jedie merged commit 64bdf35 into jedie:master Aug 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants